Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case of children for images that are FROM a SharedTag #32

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Fix edge case of children for images that are FROM a SharedTag #32

merged 1 commit into from
Aug 16, 2021

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 16, 2021

Before:

$ bashbrew children --uniq adoptopenjdk | wc -l
4
$ bashbrew children --uniq adoptopenjdk | cut -d: -f1 | sort -u
cassandra

After:

$ bashbrew children --uniq adoptopenjdk | wc -l
82
$ bashbrew children --uniq adoptopenjdk | cut -d: -f1 | sort -u
cassandra
gradle
groovy
maven
open-liberty
tomcat
websphere-liberty

@tianon
Copy link
Member Author

tianon commented Aug 16, 2021

(Probably best to review without whitespace, ala https://github.com/docker-library/bashbrew/pull/32/files?w=1)

@tianon tianon mentioned this pull request Aug 16, 2021
Merged
@tianon tianon merged commit 4c95a9e into docker-library:master Aug 16, 2021
@tianon tianon deleted the shared-tags-children branch August 16, 2021 20:05
tianon added a commit that referenced this pull request Aug 16, 2021
@tianon
Remove unnecessary extra "if"
1eebbf3 
This is something I missed in #32 😅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianon @yosifkit